source-only mode: add initial document #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluent/fluentd#4661 Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Watson1978
reviewed
Jan 14, 2025
Watson1978
reviewed
Jan 14, 2025
Watson1978
reviewed
Jan 14, 2025
Watson1978
reviewed
Jan 14, 2025
Watson1978
reviewed
Jan 14, 2025
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
cosmo0920
reviewed
Jan 14, 2025
Contributor
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
I commented several concerns at the first glance.
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Contributor
Author
|
@cosmo0920 |
kenhys
reviewed
Jan 15, 2025
kenhys
reviewed
Jan 15, 2025
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Shizuo Fujita <fujita@clear-code.com> Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>
Contributor
Author
|
Thanks for your review!! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluent/fluentd#4661