installation: refactor filepaths #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not affect the views. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
kenhys
reviewed
Jan 21, 2025
Contributor
kenhys
left a comment
kenhys
left a comment
There was a problem hiding this comment.
It is good to refactor under sub-directory, but directory name seems a bit redundant.
How about changing like this?
installation/calyptia-fluentd/...
installation/fluent-package/...
Contributor
Author
|
The problem is that it will change the current URL. If we prefer not to change this, we need to make the name On the other hand, since this URL was created recently, there might be a way of thinking like, "Let's change it." What do you think? |
kenhys
approved these changes
Jan 22, 2025
Contributor
kenhys
left a comment
kenhys
left a comment
There was a problem hiding this comment.
LGTM.
installation/install-fluent-package/... URL will be assigned automatically,
it is better not to shorten. let it gitbook.
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluent-packagein https://docs.fluentd.org/installation/install-fluent-package in the future.This does not affect the views.