benchmark: Use IO#size instead of File.size to speed up file generation on Windows#5277
Merged
kenhys merged 1 commit intofluent:masterfrom Mar 16, 2026
Merged
benchmark: Use IO#size instead of File.size to speed up file generation on Windows#5277kenhys merged 1 commit intofluent:masterfrom
kenhys merged 1 commit intofluent:masterfrom
Conversation
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
approved these changes
Mar 16, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 22, 2026
…on on Windows (#5277) **Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Using `File.size(path)` in a tight loop is very slow, especially on Windows, because it resolves the path and calls `stat` every time. * benchmark code ```ruby require 'bundler/inline' gemfile do source 'https://rubygems.org' gem 'benchmark-ips' end FILE_PATH = "dummy_file.txt" File.open(FILE_PATH, "w") do |f| Benchmark.ips do |x| x.time = 10 x.report("File.size(path)") { File.size(FILE_PATH) } x.report("File#size") { f.size } end end ``` * result ``` ruby 4.0.1 (2026-01-13 revision e04267a14b) +PRISM [x64-mingw-ucrt] Warming up -------------------------------------- File.size(path) 3.104k i/100ms File#size 17.874k i/100ms Calculating ------------------------------------- File.size(path) 31.099k (± 1.5%) i/s (32.16 μs/i) - 313.504k in 10.083209s File#size 182.821k (± 1.4%) i/s (5.47 μs/i) - 1.841M in 10.072168s ``` Using the instance method `IO#size` (f.size) avoids this overhead and speeds up the 1GB test file generation by about 5x (from ~45s to ~9s) in https://github.com/fluent/fluentd/blob/b819ccf772e1036adb17f49682c6b7053713066d/tasks/benchmark.rb#L13-L23 **Docs Changes**: N/A **Release Note**: N/A Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Using
File.size(path)in a tight loop is very slow, especially on Windows,because it resolves the path and calls
statevery time.Using the instance method
IO#size(f.size) avoids this overhead andspeeds up the 1GB test file generation by about 5x (from ~45s to ~9s) in
fluentd/tasks/benchmark.rb
Lines 13 to 23 in b819ccf
Docs Changes:
N/A
Release Note:
N/A