parser_tsv: Improve parse performance and reduce memory allocation#5344
Merged
Conversation
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
This commit replaces
Hash[@keys.zip(values)]with awhileloop inTSVParser#parse.The previous implementation using
Array#zipcreated multiple short-lived intermediate arrays per line, which caused significant GC pressure when processing a large amount of logs.By using a simple
whileloop and direct hash assignment, we can completely eliminate these intermediate object allocations.Furthermore, because
Array#zipis implemented in C natively, it leaves little room for Ruby's JIT compilers.Micro benchmark
Docs Changes:
N/A
Release Note: