-
Notifications
You must be signed in to change notification settings - Fork 1.4k
560 - exclude files from tail #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
560 - exclude files from tail #561
Conversation
|
Thanks! |
lib/fluent/plugin/in_tail.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exclude_path is good because exclude is too confusion name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've made this change...
Lance N on the group mailing list mentioned that you can use format null using a tag to filter this, however this still means your processing the files and tailing them, at least this is my assumption from what the code I've seen is doing.
In my current example I still think the patch is appropriate to avoid any overhead.
The docker container in my case handles all logging. This means all logs would be duplicated by tailing this particular containers log file.
|
I will merge this PR today if there is no any concern from other users. |
|
LGTM |
|
Need to add some docs for this, but will be good to get merged. Thanks |
560 - exclude files from tail
|
Thanks! |
560 - exclude files from tail
|
cherry-picked to v0.10 |
560 - exclude files from tail