Skip to content

Conversation

@ajohnstone
Copy link
Contributor

560 - exclude files from tail

@repeatedly repeatedly self-assigned this Mar 10, 2015
@repeatedly
Copy link
Member

Thanks!
I will check it later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclude_path is good because exclude is too confusion name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made this change...

Lance N on the group mailing list mentioned that you can use format null using a tag to filter this, however this still means your processing the files and tailing them, at least this is my assumption from what the code I've seen is doing.

In my current example I still think the patch is appropriate to avoid any overhead.
The docker container in my case handles all logging. This means all logs would be duplicated by tailing this particular containers log file.

@repeatedly
Copy link
Member

I will merge this PR today if there is no any concern from other users.

@tagomoris
Copy link
Member

LGTM

@ajohnstone
Copy link
Contributor Author

Need to add some docs for this, but will be good to get merged.

Thanks

repeatedly added a commit that referenced this pull request Mar 19, 2015
@repeatedly repeatedly merged commit b1208e0 into fluent:master Mar 19, 2015
@ajohnstone ajohnstone deleted the 560-exclude-files-from-tail branch March 19, 2015 09:39
@repeatedly
Copy link
Member

Thanks!

repeatedly added a commit that referenced this pull request Apr 19, 2015
@sonots
Copy link
Member

sonots commented Apr 19, 2015

cherry-picked to v0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants