Skip to content

Conversation

@kalintou
Copy link

@kalintou kalintou commented Apr 4, 2024

Ⅰ. Describe what this PR does

Fixed #3796
this pr is to corrected 'transfromer' to 'transformers' of file pkg\dataprocess\generate_values_test.go:24:47:

Signed-off-by: kalintou <monkeyboyer.ks@gmail.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 4, 2024

Hi @kalintou. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@LiYuhang9527
Copy link
Contributor

look good to me

@RongGu
Copy link
Member

RongGu commented Apr 22, 2024

/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Collaborator

cheyang commented Apr 22, 2024

@kalintou Please check if the golang program can be compiled. Thanks.

@cheyang cheyang removed the approved label Apr 24, 2024
@cheyang cheyang closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] fix typo in changelog

4 participants