Skip to content

This PR is to add comments to TestAlluxioEngine_getGracefulShutdownLimits in pkg\ddc\alluxio\cache_test.go.#4533

Merged
cheyang merged 1 commit intofluid-cloudnative:masterfrom
huuga513:add-comments
Apr 21, 2025
Merged

This PR is to add comments to TestAlluxioEngine_getGracefulShutdownLimits in pkg\ddc\alluxio\cache_test.go.#4533
cheyang merged 1 commit intofluid-cloudnative:masterfrom
huuga513:add-comments

Conversation

@huuga513
Copy link
Copy Markdown
Contributor

@huuga513 huuga513 commented Mar 5, 2025

…c\alluxio\cache_test.go.

Ⅰ. Describe what this PR does

Add comments to TestAlluxioEngine_getGracefulShutdownLimits in pkg\ddc\alluxio\cache_test.go.

Ⅱ. Does this pull request fix one issue?

fixes #4532

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 5, 2025

Hi @huuga513. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @huuga513, please fix the DCO Issue by following https://github.com/fluid-cloudnative/fluid/pull/4533/checks?check_run_id=38237118659

@huuga513 huuga513 force-pushed the add-comments branch 3 times, most recently from 7306819 to f1d0e93 Compare March 6, 2025 15:12
…c\alluxio\cache_test.go.

Signed-off-by: huuga513 <high5132@outlook.com>
@huuga513 huuga513 force-pushed the add-comments branch 2 times, most recently from 3a01789 to 5cb4608 Compare March 28, 2025 15:36
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit b15502c into fluid-cloudnative:master Apr 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestAlluxioEngine_getGracefulShutdownLimits in pkg\ddc\alluxio\cache_test.go

3 participants