Skip to content

This PR is to add comments to TestTransformMasterProperties in pkg\ddc\alluxio\transform_test.go.#4542

Merged
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
cocodechen:fluid2_branch
Mar 10, 2025
Merged

This PR is to add comments to TestTransformMasterProperties in pkg\ddc\alluxio\transform_test.go.#4542
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
cocodechen:fluid2_branch

Conversation

@cocodechen
Copy link
Copy Markdown
Contributor

@cocodechen cocodechen commented Mar 6, 2025

Ⅰ. Describe what this PR does
add comments to TestTransformMasterProperties in pkg\ddc\alluxio\transform_test.go.
Ⅱ. Does this pull request fix one issue?
fixes #4548, fixes #4541
Ⅲ. Special notes for reviews
the issue#4541 is Chinese and the issue #4548 is English,and the comment in this request is English,so you can accpet it to close two issues

…sform_test.go.

Signed-off-by: cocodechen <2570667128@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot bot commented Mar 6, 2025

Hi @cocodechen. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @cocodechen, please ensure that the comments are in English. Thanks.

…sform_test.go.

Signed-off-by: cocodechen <2570667128@qq.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 6, 2025

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit b9fae99 into fluid-cloudnative:master Mar 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants