Skip to content

This PR is to add comments to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.#4586

Merged
cheyang merged 2 commits intofluid-cloudnative:masterfrom
ackerm0n:lab1
Apr 27, 2025
Merged

This PR is to add comments to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.#4586
cheyang merged 2 commits intofluid-cloudnative:masterfrom
ackerm0n:lab1

Conversation

@ackerm0n
Copy link
Copy Markdown
Contributor

@ackerm0n ackerm0n commented Mar 9, 2025 •
edited
Loading

Ⅰ. Describe what this PR does
This PR is to add comments to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.
Ⅱ. Does this pull request fix one issue?
fixes Add comments/notation to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.#4585
Ⅲ. Special notes for reviews
update to English

Add comments/notation to TestTransformShortCircuit in pkg\ddc\alluxio…
a83067c 
…\transform_test.go.

Signed-off-by: windows <1525454094@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 9, 2025

Hi @ackerm0n. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

JiGuoDing commented Mar 9, 2025

Hello @ackerm0n, please ensure that the comments are in English.

cheyang
cheyang requested changes Mar 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments of this method in English.

Add note in English
8bef50a 
Signed-off-by: windows <1525454094@qq.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ackerm0n
Copy link
Copy Markdown
Contributor Author

ackerm0n commented Apr 5, 2025

I've added note in English. Could I know why not pass?

@ackerm0n ackerm0n requested a review from cheyang April 7, 2025 11:40
cheyang
cheyang approved these changes Apr 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit f9b05dc into fluid-cloudnative:master Apr 27, 2025
3 of 4 checks passed
cheyang pushed a commit to ackerm0n/fluid that referenced this pull request Apr 30, 2025
@ackerm0n @cheyang
This PR is to add comments to TestTransformShortCircuit in pkg\ddc\al…
081a81c 
…luxio\transform_test.go. (fluid-cloudnative#4586)

* Add comments/notation to TestTransformShortCircuit in pkg\ddc\alluxio\transform_test.go.

Signed-off-by: windows <1525454094@qq.com>

* Add note in English

Signed-off-by: windows <1525454094@qq.com>

---------

Signed-off-by: windows <1525454094@qq.com>
Co-authored-by: windows <1525454094@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ackerm0n @JiGuoDing @cheyang