Skip to content

This PR is to add commentsto TestJindoEngine_DeleteFusePersistentVolumeClaim in pkg\ddc\jindo\delete_volume_test.go#4632

Merged
cheyang merged 3 commits intofluid-cloudnative:masterfrom
user297370852:fluid-gittask
Mar 20, 2025
Merged

This PR is to add commentsto TestJindoEngine_DeleteFusePersistentVolumeClaim in pkg\ddc\jindo\delete_volume_test.go#4632
cheyang merged 3 commits intofluid-cloudnative:masterfrom
user297370852:fluid-gittask

Conversation

@user297370852
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

This PR is to add commentsto TestJindoEngine_DeleteFusePersistentVolumeClaim in pkg\ddc\jindo\delete_volume_test.go

Ⅱ. Does this pull request fix one issue?

fixes #4631

Ⅲ. Special notes for reviews

nothing more

…sting.T) in pkg\ddc\jindo\delete_volume_test.go

Signed-off-by: user297370852 <221870222@smail.nju.edu.cn>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot bot commented Mar 11, 2025

Hi @user297370852. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @user297370852, please do not add comments inside the functions, and all you need to do is add comments before the function. Thanks

…g\ddc\jindo\delete_volume_test.go

Signed-off-by: user297370852 <221870222@smail.nju.edu.cn>
@user297370852
Copy link
Copy Markdown
Contributor Author

Hello @user297370852, please do not add comments inside the functions, and all you need to do is add comments before the function. Thanks

I've removed the comments inside the function, making sure the comments are in front of the function body. Could you please review the latest changes? Thank you!

Signed-off-by: cheyang <cheyang@163.com>
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

@cheyang cheyang merged commit 409ec84 into fluid-cloudnative:master Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestJindoEngine_DeleteFusePersistentVolumeClaim in pkg\ddc\jindo\delete_volume_test.go.

3 participants