Skip to content

Upgrade golang 1.23.7#4796

Merged
cheyang merged 2 commits intofluid-cloudnative:masterfrom
cheyang:upgrade_golang_1.23.7
Mar 25, 2025
Merged

Upgrade golang 1.23.7#4796
cheyang merged 2 commits intofluid-cloudnative:masterfrom
cheyang:upgrade_golang_1.23.7

Conversation

@cheyang
Copy link
Copy Markdown
Collaborator

@cheyang cheyang commented Mar 20, 2025

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cheyang added 2 commits March 20, 2025 11:39
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link
Copy Markdown

@cheyang
Copy link
Copy Markdown
Collaborator Author

cheyang commented Mar 20, 2025

/test fluid-e2e

@@ -1,6 +1,6 @@
# Build the fluidapp-controller manager binary
# golang:1.22.10-bullseye
FROM golang@sha256:1e3e0cdab013c62de8c3f4fe942138255e6a367b90079220ed6f3853a34329ff as builder
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we stop pinning image's hash?

@cheyang cheyang requested a review from TrafalgarZZZ March 21, 2025 08:31
@cheyang
Copy link
Copy Markdown
Collaborator Author

cheyang commented Mar 25, 2025

/retest

Copy link
Copy Markdown
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cheyang cheyang merged commit 0b77dc2 into fluid-cloudnative:master Mar 25, 2025
15 of 16 checks passed
@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Mar 25, 2025
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants