Skip to content

Conversation

@JiGuoDing
Copy link
Collaborator

Ⅰ. Describe what this PR does

This PR tries to replace read-all with specific permissions for security reasons.

Ⅱ. Does this pull request fix one issue?

fixes #5436

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…in .github/workflows/codeql-analysis.yml.

Signed-off-by: JiGuoDing <485204300@qq.com>
Copilot AI review requested due to automatic review settings January 21, 2026 08:09
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a security issue by replacing overly permissive permissions: read-all with specific permissions in the CodeQL workflow, following the principle of least privilege as recommended in issue #5436.

Changes:

  • Replaced permissions: read-all with explicit contents: read and actions: write permissions at the workflow level

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: JiGuoDing <485204300@qq.com>
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.25%. Comparing base (668b65b) to head (9df7cbe).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5437   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files         443      443           
  Lines       30735    30735           
=======================================
  Hits        17290    17290           
  Misses      11880    11880           
  Partials     1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 12b5654 into fluid-cloudnative:master Jan 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Read-all and Write-all permissions should not be used in .github/workflows/codeql-analysis.yml.

2 participants