-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(security): Read-all and Write-all permissions should not be used in .github/workflows/codeql-analysis.yml. #5437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in .github/workflows/codeql-analysis.yml. Signed-off-by: JiGuoDing <485204300@qq.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a security issue by replacing overly permissive permissions: read-all with specific permissions in the CodeQL workflow, following the principle of least privilege as recommended in issue #5436.
Changes:
- Replaced
permissions: read-allwith explicitcontents: readandactions: writepermissions at the workflow level
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: JiGuoDing <485204300@qq.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5437 +/- ##
=======================================
Coverage 56.25% 56.25%
=======================================
Files 443 443
Lines 30735 30735
=======================================
Hits 17290 17290
Misses 11880 11880
Partials 1565 1565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
This PR tries to replace
read-allwith specific permissions for security reasons.Ⅱ. Does this pull request fix one issue?
fixes #5436
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews