Skip to content

test(ddc/goosefs): migrate transform_api_gateway tests to ginkgo#5554

Merged
TrafalgarZZZ merged 2 commits intofluid-cloudnative:masterfrom
hxrshxz:ginkgo/goosefs-transform-api-gateway
Feb 11, 2026
Merged

test(ddc/goosefs): migrate transform_api_gateway tests to ginkgo#5554
TrafalgarZZZ merged 2 commits intofluid-cloudnative:masterfrom
hxrshxz:ginkgo/goosefs-transform-api-gateway

Conversation

@hxrshxz
Copy link
Copy Markdown
Contributor

@hxrshxz hxrshxz commented Jan 28, 2026

Ⅰ. Describe what this PR does

Migrate unit tests in pkg/ddc/goosefs/transform_api_gateway_test.go to use Ginkgo/Gomega.

Ⅱ. Does this pull request fix one issue?

part of #5407

Ⅲ. List the added test cases

No new test cases. Migrated existing tests to Ginkgo/Gomega.

Ⅳ. Describe how to verify it

go test -v ./pkg/ddc/goosefs/... -count=1

Ⅴ. Special notes for reviews

N/A

Signed-off-by: Harsh <harshmastic@gmail.com>
Copilot AI review requested due to automatic review settings January 28, 2026 07:57
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Jan 28, 2026

Hi @hxrshxz. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates unit tests in pkg/ddc/goosefs/transform_api_gateway_test.go from the testify framework to Ginkgo/Gomega as part of the broader initiative (#5407) to standardize Fluid's testing framework. The migration replaces traditional table-driven tests with Ginkgo's DescribeTable structure for better readability and BDD-style organization.

Changes:

  • Replaced testify imports with Ginkgo/Gomega imports
  • Converted function-based tests to Ginkgo's Describe and DescribeTable structure
  • Restructured test cases as Entry declarations with descriptive names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/ddc/goosefs/transform_api_gateway_test.go
Comment thread pkg/ddc/goosefs/transform_api_gateway_test.go Outdated
Comment thread pkg/ddc/goosefs/transform_api_gateway_test.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.08%. Comparing base (57dae80) to head (9241b6b).
⚠️ Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5554      +/-   ##
==========================================
+ Coverage   57.70%   59.08%   +1.38%     
==========================================
  Files         444      444              
  Lines       30424    30431       +7     
==========================================
+ Hits        17555    17981     +426     
+ Misses      11396    10945     -451     
- Partials     1473     1505      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hxrshxz hxrshxz marked this pull request as draft January 28, 2026 09:10
Signed-off-by: Harsh <harshmastic@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

@hxrshxz hxrshxz marked this pull request as ready for review February 6, 2026 19:15
Copy link
Copy Markdown
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ TrafalgarZZZ merged commit 997e8fd into fluid-cloudnative:master Feb 11, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants