test(ddc/goosefs): migrate transform_api_gateway tests to ginkgo#5554
Conversation
Signed-off-by: Harsh <harshmastic@gmail.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Hi @hxrshxz. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR migrates unit tests in pkg/ddc/goosefs/transform_api_gateway_test.go from the testify framework to Ginkgo/Gomega as part of the broader initiative (#5407) to standardize Fluid's testing framework. The migration replaces traditional table-driven tests with Ginkgo's DescribeTable structure for better readability and BDD-style organization.
Changes:
- Replaced testify imports with Ginkgo/Gomega imports
- Converted function-based tests to Ginkgo's
DescribeandDescribeTablestructure - Restructured test cases as
Entrydeclarations with descriptive names
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
+ Coverage 57.70% 59.08% +1.38%
==========================================
Files 444 444
Lines 30424 30431 +7
==========================================
+ Hits 17555 17981 +426
+ Misses 11396 10945 -451
- Partials 1473 1505 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Harsh <harshmastic@gmail.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
Migrate unit tests in pkg/ddc/goosefs/transform_api_gateway_test.go to use Ginkgo/Gomega.
Ⅱ. Does this pull request fix one issue?
part of #5407
Ⅲ. List the added test cases
No new test cases. Migrated existing tests to Ginkgo/Gomega.
Ⅳ. Describe how to verify it
go test -v ./pkg/ddc/goosefs/... -count=1Ⅴ. Special notes for reviews
N/A