test(utils): migrate tests to ginkgo of pkg/utils/kubeclient/rbac_test.go#5579
Conversation
Summary of ChangesHello @adity1raut, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors several unit tests within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @adity1raut. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates tests in pkg/utils/kubeclient/rbac_test.go and pkg/webhook/plugins/requirenodewithfuse/require_node_with_fuse_test.go to use the Ginkgo testing framework. The changes are well-structured and follow Ginkgo conventions. I've added a couple of suggestions to further improve the tests. One suggestion is to make the deletion tests in rbac_test.go more robust by verifying that the resources are actually deleted. The other is to refactor a large test case in require_node_with_fuse_test.go into smaller, more focused tests for better readability and maintainability.
| err := DeleteServiceAccount(fakeClient, "test1", namespace) | ||
| Expect(err).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
This test only asserts that no error is returned. To be more thorough, it should also verify that the ServiceAccount is actually deleted. You can do this by attempting to Get the resource after deletion and expecting a NotFound error.
This same improvement can be applied to the tests for DeleteRole and DeleteRoleBinding.
You will need to add the following imports:
import (
"context"
apierrors "k8s.io/apimachinery/pkg/api/errors"
)err := DeleteServiceAccount(fakeClient, "test1", namespace)
Expect(err).NotTo(HaveOccurred())
sa := &corev1.ServiceAccount{}
err = fakeClient.Get(context.TODO(), client.ObjectKey{Name: "test1", Namespace: namespace}, sa)
Expect(apierrors.IsNotFound(err)).To(BeTrue())| It("should create plugin and mutate pod correctly", func() { | ||
| plugin, err := NewPlugin(cl, "") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(plugin.GetName()).To(Equal(Name)) | ||
|
|
||
| runtimeInfo, err := base.BuildRuntimeInfo("test", "fluid", "alluxio") | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| shouldStop, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"pvcName": runtimeInfo}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(shouldStop).To(BeFalse()) | ||
|
|
||
| _, err = plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| _, err = plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"pvcName": nil}) | ||
| Expect(err).To(HaveOccurred()) | ||
| }) |
There was a problem hiding this comment.
This test case covers multiple scenarios (plugin creation, name check, and various mutation cases). It's a good practice in BDD-style testing to have one specific expectation per It block. Consider refactoring this into multiple, more focused It blocks. This improves readability and makes it easier to pinpoint failures.
You may need to add an import for github.com/fluid-cloudnative/fluid/pkg/webhook/plugins/api.
It("should create plugin and get name correctly", func() {
plugin, err := NewPlugin(cl, "")
Expect(err).NotTo(HaveOccurred())
Expect(plugin.GetName()).To(Equal(Name))
})
Context("when mutating pod", func() {
var plugin api.MutatingHandler
BeforeEach(func() {
var err error
plugin, err = NewPlugin(cl, "")
Expect(err).NotTo(HaveOccurred())
})
It("should not stop and not error with valid runtime info", func() {
runtimeInfo, err := base.BuildRuntimeInfo("test", "fluid", "alluxio")
Expect(err).NotTo(HaveOccurred())
shouldStop, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"pvcName": runtimeInfo})
Expect(err).NotTo(HaveOccurred())
Expect(shouldStop).To(BeFalse())
})
It("should not stop and not error with empty runtime info map", func() {
_, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{})
Expect(err).NotTo(HaveOccurred())
})
It("should error with nil runtime info", func() {
_, err := plugin.Mutate(pod, map[string]base.RuntimeInfoInterface{"pvcName": nil})
Expect(err).To(HaveOccurred())
})
})
…t.go Signed-off-by: adity1raut <araut7798@gmail.com>
adity1raut
force-pushed
the
kubeclient_5
branch
from
7eb2941 to
0e6d1fe
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5579 +/- ##
==========================================
+ Coverage 59.07% 59.22% +0.15%
==========================================
Files 444 444
Lines 30431 30431
==========================================
+ Hits 17978 18024 +46
+ Misses 10947 10912 -35
+ Partials 1506 1495 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
part of #5407
pkg/utils/kubeclient/rbac_test.go
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews