Skip to content

refactor(alluxio): reorganize and format alluxio engine internal func…#5789

Merged
RongGu merged 1 commit intofluid-cloudnative:masterfrom
cheyang:fix_gmt_issue
Apr 16, 2026
Merged

refactor(alluxio): reorganize and format alluxio engine internal func…#5789
RongGu merged 1 commit intofluid-cloudnative:masterfrom
cheyang:fix_gmt_issue

Conversation

@cheyang
Copy link
Copy Markdown
Collaborator

@cheyang cheyang commented Apr 16, 2026

…tions

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Copy Markdown
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

…tions

Signed-off-by: cheyang <cheyang.cy@alibaba-inc.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Apr 16, 2026
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RongGu RongGu merged commit 61b67ae into fluid-cloudnative:master Apr 16, 2026
14 of 16 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a minor formatting change in pkg/ddc/alluxio/ufs_internal.go, adding a newline between the processUpdatingUFS function and the documentation for updatingUFSWithMountCommand. There are no review comments to address, and I have no feedback to provide.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.46%. Comparing base (fff7cb5) to head (895326c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5789   +/-   ##
=======================================
  Coverage   58.46%   58.46%           
=======================================
  Files         473      473           
  Lines       32222    32222           
=======================================
  Hits        18839    18839           
  Misses      11836    11836           
  Partials     1547     1547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants