Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

feat(build): #1043 support nodejs 18 #1208

Merged
dsalaza4 merged 1 commit into from
Dec 13, 2023
Merged

feat(build): #1043 support nodejs 18 #1208

dsalaza4 merged 1 commit into from
Dec 13, 2023

Conversation

@rohaquinlop
Copy link
Contributor

@rohaquinlop rohaquinlop commented Dec 7, 2023

  • update nodejs version to 18

@rohaquinlop rohaquinlop force-pushed the issue-1043 branch 6 times, most recently from 86b6411 to 69e58bc Compare December 13, 2023 16:37
@rohaquinlop
Copy link
Contributor Author

rohaquinlop commented Dec 13, 2023

I'm thinking that will be necessary to refactor makeNodeJsLock to only receive the node_js_version and the path that contains the package.json file, no other parameters will be necessaries to generate the package-lock.json file correctly.

@rohaquinlop rohaquinlop mentioned this pull request Dec 13, 2023
Closed
2 tasks
dsalaza4
dsalaza4 reviewed Dec 13, 2023
View reviewed changes
@rohaquinlop
feat(build): fluidattacks#1043 support nodejs 18
ddc7265 
- update nodejs version to 18

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

dsalaza4
dsalaza4 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@dsalaza4 dsalaza4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dsalaza4 dsalaza4 merged commit fbc4ab7 into fluidattacks:main Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dsalaza4 dsalaza4 dsalaza4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohaquinlop @dsalaza4