fix: Cartographer simple integration #1736
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new [cartographer] configuration section in Klipper, which provides two calibration commands: CARTOGRAPHER_SCAN_CALIBRATE and CARTOGRAPHER_TOUCH_CALIBRATE. This update addresses the migration from the older [scanner] section approach to the dedicated [cartographer] section.
Key Changes:
- Added type definition for the
cartographersettings section - Added wait constants for the two new Cartographer calibration commands
- Updated probe detection and added dedicated Cartographer calibration tool support in ToolheadCard
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/store/printer/types.ts | Added cartographer property to printer settings type, reusing the existing KlipperPrinterCartographerScannerSettings interface |
| src/globals.ts | Added wait constants onCartographerScanCalibrate and onCartographerTouchCalibrate for async command tracking |
| src/components/widgets/toolhead/ToolheadCard.vue | Added Cartographer support to probe detection, created dedicated getter for Cartographer calibration support, and added the two calibration tool entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cartographer is now using
[cartographer]as a settings section, so this will now detect this usage and include theCARTOGRAPHER_SCAN_CALIBRATEandCARTOGRAPHER_TOUCH_CALIBRATEwhen it finds the section.Fixes #1735