feat: configurable warnings settings#1700
Merged
pedrolamas merged 1 commit intofluidd-core:developfrom Aug 10, 2025
Merged
Conversation
pedrolamas
force-pushed
the
pedrolamas/warnings-settings
branch
from
2c000f3 to
239e8aa
Compare
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
force-pushed
the
pedrolamas/warnings-settings
branch
from
239e8aa to
dc76b32
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new "Warnings" settings section to the UI, allowing users to configure warning notifications for CPU throttling and stepper driver overheating. This resolves issue #1474 by giving users control over these specific warnings.
- Adds a new WarningsSettings component with toggles for CPU throttling and stepper driver overheating warnings
- Updates server action logic to respect the new warning configuration settings
- Provides localization strings for the new warning settings interface
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/views/Settings.vue | Integrates the new WarningsSettings component into the main settings view |
| src/store/server/actions.ts | Updates CPU throttling notification logic to check warning configuration |
| src/store/helpers.ts | Updates stepper driver overheating logic to check warning configuration |
| src/store/config/types.ts | Defines the WarningsConfig interface for the new settings |
| src/store/config/state.ts | Provides default values for the warning configuration settings |
| src/locales/en.yaml | Adds English translations for the new warning settings labels and tooltips |
| src/components/settings/WarningsSettings.vue | New component providing the warnings configuration interface |
| src/components/layout/AppSettingsNav.vue | Adds navigation item for the warnings settings section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new settings section for Warnings, allowing users to selectively disable warnings for CPU Throttling (only reported for Raspberry Pi devices) and stepper driver overheating (currently only for the TMC2204).
Resolves #1474
Warnings Settings