fix(HappyHare): EMU Logo SVG fix for dark themes #1769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mmu_EMU.svg with addtional SVG tags so that it renders correclty in all themes. Signed-off-by: David Watson <dwatson.tas@outlook.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Member
|
Hi @DW-Tas, thank you for opening this Pull Request. I've pre-processed the SVG file with SVGO as we normally, can I ask that you please pull the latest and check that your fix is still working as expected? |
Contributor
Author
|
Good morning @pedrolamas, I downloaded the latest build and copied the SVG into my docker container running fluidd. Have confirmed with "inspect element" that the optimised SVG is loading, and it is displaying correctly in both light and dark themes. Thank you! |
pedrolamas
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mmu_EMU.svg with additional SVG tags so that it renders correctly in all themes.
The EMU MMU logo does not render properly when the primary colours are inverted. This update SVG includes additional tags to ensure that it renders correctly in both light and dark themes. It has been tested across light and dark modes for multiple community preset themes.
New SVG dark theme:
New SVG light theme:
Old SVG dark theme (the issue being fixed):
