Skip to content

fix(HappyHare): Fixes sync-feedback buffer state output in visualization and supports analog sensors#1787

Merged
pedrolamas merged 3 commits intofluidd-core:developfrom
moggieuk:sync_feedback_fixes
Feb 12, 2026
Merged

fix(HappyHare): Fixes sync-feedback buffer state output in visualization and supports analog sensors#1787
pedrolamas merged 3 commits intofluidd-core:developfrom
moggieuk:sync_feedback_fixes

Conversation

@moggieuk
Copy link
Contributor

@moggieuk moggieuk commented Feb 12, 2026

Description

This PR fixes the incorrect display of sync-feedback buffer state on certain sensor types. Happy Hare supports dual-switch sensors, compression-only switch, tension-only switch as well as newer analog (proportional) sensors. Previously the code looked at sensor switch state for these annotations. Now it uses the Happy Hare support status which allows for configuration on the zone for tension/compressed states. It also now works correctly with analog/proportional sensors.

Related Tickets & Documents

n/a

Mobile & Desktop Screenshots/Recordings

The buffer rendering is unchanged except for the correct display of "Neutral", "Compressed", or "Tension" status under all conditions:
sync_feedback_fixes_after

Signed-off-by: Paul Morgan moggieuk@hotmail.com

@pedrolamas pedrolamas added the GH - Bug Something isn't working label Feb 12, 2026
@pedrolamas pedrolamas added this to the 1.36.3 milestone Feb 12, 2026
@pedrolamas pedrolamas requested a review from Copilot February 12, 2026 17:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes MMU (Happy Hare) sync-feedback buffer state visualization by using Happy Hare’s reported sync_feedback_state instead of deriving the state from sensor switch triggers, improving correctness across switch-based and proportional/analog sensors.

Changes:

  • Add syncFeedbackState accessor + sync-feedback state constants to the MMU mixin.
  • Update MmuFilamentStatus buffer annotation logic to render Neutral/Tension/Compressed based on sync_feedback_state.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/mixins/mmu.ts Exposes syncFeedbackState and sync-feedback state constants for UI consumers.
src/components/widgets/mmu/MmuFilamentStatus.vue Switches buffer-state rendering conditions to use syncFeedbackState comparisons.
Comments suppressed due to low confidence (1)

src/components/widgets/mmu/MmuFilamentStatus.vue:477

  • PR description/screenshot text mentions showing "Compressed", but the UI label rendered for the compressed state is "Compression". If the intended user-facing state is the adjective form, update the label (or adjust the PR description to match the UI wording).
              v-else-if="syncFeedbackState === SYNC_FEEDBACK_COMPRESSED"
              key="compression"
            >
              <text
                x="298"
                y="240"
              >
                Compression
              </text>

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@pedrolamas pedrolamas merged commit ea4e7e0 into fluidd-core:develop Feb 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GH - Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants