fix(HappyHare): Fixes sync-feedback buffer state output in visualization and supports analog sensors#1787
Merged
pedrolamas merged 3 commits intofluidd-core:developfrom Feb 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes MMU (Happy Hare) sync-feedback buffer state visualization by using Happy Hare’s reported sync_feedback_state instead of deriving the state from sensor switch triggers, improving correctness across switch-based and proportional/analog sensors.
Changes:
- Add
syncFeedbackStateaccessor + sync-feedback state constants to the MMU mixin. - Update
MmuFilamentStatusbuffer annotation logic to render Neutral/Tension/Compressed based onsync_feedback_state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/mixins/mmu.ts |
Exposes syncFeedbackState and sync-feedback state constants for UI consumers. |
src/components/widgets/mmu/MmuFilamentStatus.vue |
Switches buffer-state rendering conditions to use syncFeedbackState comparisons. |
Comments suppressed due to low confidence (1)
src/components/widgets/mmu/MmuFilamentStatus.vue:477
- PR description/screenshot text mentions showing "Compressed", but the UI label rendered for the compressed state is "Compression". If the intended user-facing state is the adjective form, update the label (or adjust the PR description to match the UI wording).
v-else-if="syncFeedbackState === SYNC_FEEDBACK_COMPRESSED"
key="compression"
>
<text
x="298"
y="240"
>
Compression
</text>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the incorrect display of sync-feedback buffer state on certain sensor types. Happy Hare supports dual-switch sensors, compression-only switch, tension-only switch as well as newer analog (proportional) sensors. Previously the code looked at sensor switch state for these annotations. Now it uses the Happy Hare support status which allows for configuration on the zone for tension/compressed states. It also now works correctly with analog/proportional sensors.
Related Tickets & Documents
n/a
Mobile & Desktop Screenshots/Recordings
The buffer rendering is unchanged except for the correct display of "Neutral", "Compressed", or "Tension" status under all conditions:

Signed-off-by: Paul Morgan moggieuk@hotmail.com