fix: Spoolman URL protocol#1792
Merged
pedrolamas merged 1 commit intofluidd-core:developfrom Feb 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the configured Spoolman server setting works when Moonraker provides a host/IP without a URL scheme, preventing failures when Fluidd builds URLs via new URL().
Changes:
- Prefixes the Spoolman server value with
http://when it doesn’t already start withhttp://orhttps://. - Updates URL construction in the Spoolman store getter to use the normalized value.
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
force-pushed
the
pedrolamas/fix-1791
branch
from
eed879c to
a956df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moonraker currently allows the Spoolman server to be set as just a host (without protocol), and that would break Fluidd when we use
URL()function to build the URL.This fix ensures that the setting value starts with either "http://" or "https://" and if not, it will default to "http://"
Fixes #1791