Skip to content

refactor: use dynamic view imports#1805

Merged
pedrolamas merged 1 commit intofluidd-core:developfrom
pedrolamas:pedrolamas/dynamic-view-imports
Mar 22, 2026
Merged

refactor: use dynamic view imports#1805
pedrolamas merged 1 commit intofluidd-core:developfrom
pedrolamas:pedrolamas/dynamic-view-imports

Conversation

@pedrolamas
Copy link
Copy Markdown
Member

Use dynamic imports to improve loading performance and caching capabilities

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.36.3 milestone Mar 22, 2026
@pedrolamas pedrolamas requested a review from Copilot March 22, 2026 17:23
@pedrolamas pedrolamas added the Code - Optimizations Everything that relates to code optimizations! label Mar 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors route/component loading to use dynamic imports, aiming to reduce initial bundle size and improve load-time performance/caching, while adjusting a few router-dependent call sites to avoid tighter coupling.

Changes:

  • Convert router view/component registrations to lazy-loaded dynamic imports.
  • Refactor authentication routing checks to use the shared $filters routing helpers instead of importing the router directly.
  • Make page title generation more robust/compact by composing title parts and omitting empty segments.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/store/auth/actions.ts Removes direct router import usage during logout and uses $filters helpers for navigation.
src/router/index.ts Replaces static view imports with lazy route components and switches auth/layout guard logic to reference the Vuex store directly.
src/plugins/filters.ts Adds a small helper to expose the current route name via $filters.
src/App.vue Refactors pageTitle computation to build a clean title string from optional parts (progress/instance/page).

@pedrolamas pedrolamas merged commit 52ee39d into fluidd-core:develop Mar 22, 2026
8 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/dynamic-view-imports branch March 22, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code - Optimizations Everything that relates to code optimizations!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants