refactor: use dynamic view imports#1805
Merged
pedrolamas merged 1 commit intofluidd-core:developfrom Mar 22, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors route/component loading to use dynamic imports, aiming to reduce initial bundle size and improve load-time performance/caching, while adjusting a few router-dependent call sites to avoid tighter coupling.
Changes:
- Convert router view/component registrations to lazy-loaded dynamic imports.
- Refactor authentication routing checks to use the shared
$filtersrouting helpers instead of importing the router directly. - Make page title generation more robust/compact by composing title parts and omitting empty segments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/store/auth/actions.ts |
Removes direct router import usage during logout and uses $filters helpers for navigation. |
src/router/index.ts |
Replaces static view imports with lazy route components and switches auth/layout guard logic to reference the Vuex store directly. |
src/plugins/filters.ts |
Adds a small helper to expose the current route name via $filters. |
src/App.vue |
Refactors pageTitle computation to build a clean title string from optional parts (progress/instance/page). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dynamic imports to improve loading performance and caching capabilities