fix(serve): validate config_path from env var (CodeQL path traversal)#32
Merged
Conversation
CODESEARCH_REPOS_CONFIG env var was used directly as a filesystem path without validation or canonicalization. CodeQL flagged this as 'Uncontrolled data used in path expression'. - repos.rs: validate env-var override has .json extension (fail-fast) - serve/mod.rs: canonicalize config_path before fs::metadata/load_from to resolve symlinks and normalize .. components Fixes: CodeQL alert on src/serve/mod.rs reload_if_changed()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODESEARCH_REPOS_CONFIGenv-var override has.jsonextension before accepting it (fail-fast)config_pathinreload_if_changed()before filesystem ops to resolve symlinks and..componentssrc/serve/mod.rsTest plan
cargo check✅cargo clippy -D warnings✅cargo test --lib— 363 passed ✅