fix: restore host ownership in AUR publish docker step#1225
Merged
Conversation
zonotope
approved these changes
May 16, 2026
Contributor
zonotope
left a comment
zonotope
left a comment
There was a problem hiding this comment.
Sorry, I could have sworn that I had approved this when you opened it. LGTM 👍🏾
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Arch container in contrib/aur/publish.sh chowns /work to an in-container
builderuid (1000) so makepkg can run as non-root, but leaves the bind-mounted AUR clone owned by that uid on exit. On the runner (uid 1001), the next host-sidegit addthen fails withPermission deniedwriting.git/index.lock, and the cleanup trap can't remove the work dir either — observed in the v4.0.3 publish-aur job. Fix: pass the host uid/gid into the container and chown /work back to them before the container exits.