Skip to content

iOS fixes in plugin #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
v2Nitesh wants to merge 5 commits into
base: master
Choose a base branch
from
Open

iOS fixes in plugin #2

v2Nitesh wants to merge 5 commits into from

Conversation

@v2Nitesh
Copy link

@v2Nitesh v2Nitesh commented May 20, 2019

iOS fixes in plugin

JulianBerger pushed a commit to JulianBerger/image_gallery that referenced this pull request Aug 2, 2019
@shpp-vsmaga
Merge pull request flutter-devs#2 from nruotsal/feature/upgrade-project
59667ee 
Feature/upgrade project
@Ahmadre
Copy link

Ahmadre commented Aug 8, 2019

Could someone please merge this! I tested his code and its working! Finally! 👍 good job @v2Nitesh 😮

@Ahmadre
Copy link

Ahmadre commented Aug 9, 2019

Nice work with the actualPath, but the actualPath isn't working for viewing an image in good quality, because Flutter says: Error in encoding image: /IMAGE.HEIC.

So the conversion to thumbnailPath is better. If scaled up the "thumbnails" to 1024:1024 and it's viewing is nice!

Greets
Rebar

@simar7
Copy link

simar7 commented Oct 4, 2019

Could someone merge this PR? The plugin as it stands remains broken without a valid podspec.

@Ahmadre
Copy link

Ahmadre commented Dec 21, 2019 •
edited
Loading

Hey if the creators of this package can't maintain this anymore then give it to me! We want to step forward guys! You can't ignore us like this...

@KabluBR
Copy link

KabluBR commented Jan 18, 2020

this ios fix breaks android...

@swati-kapoor
Copy link

swati-kapoor commented Apr 28, 2021

Please merge this, the plugin doesnt works with codemagic without it

@Ahmadre
Copy link

Ahmadre commented May 24, 2021

It's time to take advantage and create a new Plugin out of this!

Stay tuned guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@swati-kapoor swati-kapoor swati-kapoor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@v2Nitesh @Ahmadre @simar7 @KabluBR @swati-kapoor @amitrawal @manoj-v2