Temporarily disable weak symbols in third_party/boringssl #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

swift-kim merged 2 commits into flutter-tizen:flutter-2.2.1-tizen from swift-kim:no-weak-symbols

Jun 21, 2021

Member

swift-kim commented Jun 21, 2021

A temporary solution for flutter-tizen/flutter-tizen#140.

Disables the following definition in third_party/boringssl/src/crypto/mem.c:

#if defined(__ELF__) && defined(__GNUC__)
#define WEAK_SYMBOL_FUNC(rettype, name, args) \
  rettype name args __attribute__((weak));
...
#endif

and therefore makes the functions OPENSSL_memory_* and sdallocx local to the file as before.


          Temporarily disable weak symbols in third_party/boringssl

2bd1cdb

swift-kim requested review from a team, WonyoungChoi and bwikbs

June 21, 2021 06:18

bwikbs approved these changes

View reviewed changes

Member

bwikbs left a comment

It seems to be the best in our situation.


          Add -f option to gclient sync and move tizen_tools into home directory

94e898e

swift-kim merged commit a67e79d into flutter-tizen:flutter-2.2.1-tizen

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

79020af

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

fc715b0

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

00da484

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

ee80607

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

411c788

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

ea42094

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

9dcbcba

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

34330d2

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

b4a8c13

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

7e0d47b

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

09755df

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

0c98606

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

c003e85

…)" (#134)

This partially reverts commit a67e79d.

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

03d59f4

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

32a8c5b

…)" (#134)

This partially reverts commit a67e79d.

swift-kim pushed a commit that referenced this pull request


          Ignore the stencil in the imgui pipeline (#120)

af922f9

swift-kim added a commit that referenced this pull request


          Temporarily disable weak symbols in third_party/boringssl (#120)

ecd46e2

* Temporarily disable weak symbols in third_party/boringssl

* Add -f option to gclient sync and move tizen_tools into home directory

swift-kim added a commit that referenced this pull request


          Revert "Temporarily disable weak symbols in third_party/boringssl (#120…

a979686

…)" (#134)

This partially reverts commit a67e79d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet