Use TextInputModel's composing #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bwikbs
approved these changes
Aug 20, 2021
Member
bwikbs
left a comment
bwikbs
left a comment
There was a problem hiding this comment.
I didn't understand all the changes, but the processing logic seems very intuitive and neat.
Great job!! Thanks👍
Member
|
@flutter-tizen/maintainers Any comments? |
swift-kim
approved these changes
Aug 27, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Use composing methods of TextInputModel in preedit events callback. * Make Implementations about editing text simpler. * Remove unnecessary public methods of TizenInputMethodContext. * Fix a bug that didn't reset IMF-context when the selection base changed Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boram Bae boram21.bae@samsung.com