Fix parsing bug for dispose method #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
Member
|
Shouldn't this be fixed in the plugin side? should be await SystemChannels.platform_views.invokeMethod<void>('dispose', viewId); |
Author
|
engine/shell/platform/tizen/channels/platform_view_channel.cc Lines 180 to 184 in bdd0af4 It was initially handled using map value. |
Member
It doesn't matter. |
swift-kim
approved these changes
Aug 25, 2021
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Anyway the change looks good to me.
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map. Hence, to get a proper view_id value, it should be parsed by 'id' key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PlatformViewChannel::HandleMethodCall, a argument for 'dispose' method includes a map.
Hence, to get a proper view_id value, it should be parsed by 'id' key.