Skip to content

Migrate to Flutter 2.5.1 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Migrate to Flutter 2.5.1 #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b018fd4
Fix build for 2.5.1
swift-kim Sep 27, 2021
ff0ce44
Fix runtime errors
swift-kim Sep 27, 2021
85c9563
Remove the format job
swift-kim Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,7 @@ pr:
- flutter-*-tizen

jobs:
- job: format
pool:
name: Default
demands: Agent.os -equals Linux
steps:
- checkout: self
path: src/flutter
- bash: ci/format.sh
displayName: Verify formatting
- job: test
dependsOn: format
pool:
name: Default
demands: agent.os -equals Linux
Expand Down Expand Up @@ -85,6 +75,8 @@ jobs:
gclient sync -f -D
sed -i 's/"-Wno-non-c-typedef-for-linkage",//g' build/config/compiler/BUILD.gn
sed -i 's/"-Wno-psabi",//g' build/config/compiler/BUILD.gn
sed -i 's/"-Wno-unused-but-set-parameter",//g' build/config/compiler/BUILD.gn
sed -i 's/"-Wno-unused-but-set-variable",//g' build/config/compiler/BUILD.gn
displayName: Disable build flags
workingDirectory: $(Pipeline.Workspace)/src
failOnStderr: true
Expand Down
2 changes: 2 additions & 0 deletions ci/docker/tizen/tools/build-engine.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ else
# FIXME: Remove unsupported options of tizen toolchains from BUILD.gn.
sed -i 's/"-Wno-non-c-typedef-for-linkage",//g' src/build/config/compiler/BUILD.gn
sed -i 's/"-Wno-psabi",//g' src/build/config/compiler/BUILD.gn
sed -i 's/"-Wno-unused-but-set-parameter",//g' build/config/compiler/BUILD.gn
sed -i 's/"-Wno-unused-but-set-variable",//g' build/config/compiler/BUILD.gn

src/flutter/tools/gn \
--target-os $BUILD_OS \
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/tizen/flutter_tizen_engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ void FlutterTizenEngine::SendPointerEvent(const FlutterPointerEvent& event) {
void FlutterTizenEngine::SendWindowMetrics(int32_t width,
int32_t height,
double pixel_ratio) {
FlutterWindowMetricsEvent event;
FlutterWindowMetricsEvent event = {};
event.struct_size = sizeof(FlutterWindowMetricsEvent);
event.width = width;
event.height = height;
Expand Down
1 change: 1 addition & 0 deletions shell/platform/tizen/touch_event_handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ void TouchEventHandler::SendFlutterPointerEvent(FlutterPointerPhase phase,
event.scroll_delta_y = scroll_delta_y * 2;
event.timestamp = timestamp * 1000;
event.device = device_id;
event.device_kind = kFlutterPointerDeviceKindTouch;

engine_->SendPointerEvent(event);
}
Expand Down