Skip to content

Fix coverity issues #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2021
Merged

Fix coverity issues #196

merged 5 commits into from
Oct 27, 2021

Conversation

@bwikbs
Copy link
Member

@bwikbs bwikbs commented Oct 23, 2021

Resolve #192

bwikbs added 4 commits October 23, 2021 20:32
@bwikbs
Fix static analysis issue (coverity)
3416f3d 
* Improper use of negative value

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Fix static analysis issue (coverity)
09f011b 
* Uninitialized scalar field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Fix static analysis issue (coverity)
eb8d332 
* Logically dead code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Fix static analysis issue (coverity)
883dcac 
* Uninitialized pointer field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs bwikbs marked this pull request as ready for review October 23, 2021 12:35
swift-kim
swift-kim reviewed Oct 25, 2021
View reviewed changes
shell/platform/tizen/channels/text_input_channel.cc Outdated
: -1;

if (composing_base_value == -1 && composing_extent_value == -1) {
if (composing_base_value < 0 || composing_extent_value < 0) {
Copy link
Member

@swift-kim swift-kim Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are logically different. Did you mean

Suggested change
if (composing_base_value < 0 || composing_extent_value < 0) {
if (composing_base_value < 0 && composing_extent_value < 0) {

Copy link
Member Author

@bwikbs bwikbs Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I tried to change this.
Maybe @bbrto21 can give an opinion regarding this.

Copy link

@bbrto21 bbrto21 Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why you want to change it.
it corresponds to https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/services/text_input.dart#L765

Copy link
Member Author

@bwikbs bwikbs Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem that the static analysis tool is a problem.
image
As you see, flutter::TextRange receives size_t as an argument. The negative number can be able to produce unwanted results.

Copy link

@bbrto21 bbrto21 Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we have to cast a type from int to size_t when using TextRange constructor

Copy link
Member Author

@bwikbs bwikbs Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 It looks good in point of consistency with other platforms.

Copy link
Member

@swift-kim swift-kim Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbrto21 Hmm. Isn't it still unsafe if one of composing_base_value and composing_extent_value has a non-negative value and the other has a negative value?

Copy link
Member Author

@bwikbs bwikbs Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically it is correct.. All other ports are set like this, so it will not happen in practice area. I guess..

@bwikbs
Apply review's comment
a474471 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@swift-kim swift-kim changed the title Fix coverity Issue Fix coverity issues Oct 27, 2021
@swift-kim swift-kim merged commit 8d08f2a into flutter-tizen:flutter-2.5.1-tizen Oct 27, 2021
swift-kim pushed a commit that referenced this pull request Nov 14, 2021
@bwikbs @swift-kim
Fix coverity issues (#196)
809f7a7 
* Fix static analysis issue (coverity)

* Improper use of negative value

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Fix static analysis issue (coverity)

* Uninitialized scalar field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Fix static analysis issue (coverity)

* Logically dead code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Fix static analysis issue (coverity)

* Uninitialized pointer field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Dec 9, 2021
@bwikbs @swift-kim
Fix coverity issues (#196)
f33d68d 
* Fix static analysis issue (coverity)

* Improper use of negative value

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Fix static analysis issue (coverity)

* Uninitialized scalar field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Fix static analysis issue (coverity)

* Logically dead code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Fix static analysis issue (coverity)

* Uninitialized pointer field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Dec 17, 2021
@bwikbs @swift-kim
Fix coverity issues (#196)
2b9c0fc 
* Fix static analysis issue (coverity)

* Improper use of negative value

* Uninitialized scalar field

* Logically dead code

* Uninitialized pointer field

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Feb 7, 2022
@bwikbs @swift-kim
Fix coverity issues (#196)
ee61857 
* Fix static analysis issue (coverity)

* Improper use of negative value

* Uninitialized scalar field

* Logically dead code

* Uninitialized pointer field

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Feb 11, 2022
@bwikbs @swift-kim
Fix coverity issues (#196)
0f4637b 
* Fix static analysis issue (coverity)

* Improper use of negative value

* Uninitialized scalar field

* Logically dead code

* Uninitialized pointer field

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request May 12, 2022
@bwikbs @swift-kim
Fix coverity issues (#196)
71385db 
* Fix static analysis issue (coverity)

* Improper use of negative value

* Uninitialized scalar field

* Logically dead code

* Uninitialized pointer field

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
@bwikbs @swift-kim
Fix coverity issues (#196)
37b9475 
* Fix static analysis issue (coverity)

* Improper use of negative value

* Uninitialized scalar field

* Logically dead code

* Uninitialized pointer field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@bwikbs @swift-kim
Fix coverity issues (#196)
f5bd3fc 
* Fix static analysis issue (coverity)

* Improper use of negative value

* Uninitialized scalar field

* Logically dead code

* Uninitialized pointer field

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrto21 bbrto21 bbrto21 left review comments

@swift-kim swift-kim swift-kim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Result of coverity scan at engine

3 participants

@bwikbs @bbrto21 @swift-kim