Fix vsync issue #204
Merged
Fix vsync issue #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
After the engine is shutdown, OnVsync no longer be called.
swift-kim
reviewed
Nov 10, 2021
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
TV emulator is not currently available for me so I haven't tested the change but it generally looks good to me.
Author
I have tested 20 times, no OnVsync error. |
swift-kim
approved these changes
Nov 11, 2021
1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Fix vsync issue After the engine is shutdown, OnVsync no longer be called. * Add lock when call OnVsync 1.Remove lock when create TdmClient. 2.Add lock when call OnVsync. 3.Change tdmClient to tdm_client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the engine is shutdown, OnVsync no longer be called.