Skip to content

Refactor TizenRenderers #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2021
Merged

Refactor TizenRenderers #215

merged 1 commit into from
Dec 13, 2021

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Dec 6, 2021

Common

  • Merge InitializeRenderer and DestroyRenderer into constructors and destructors.
  • Inline GetWindowHandle.
  • Code cleanups.

Ecore Wl2

  • Combine SetupDisplay and SetupEcoreWlWindow into a single function SetupEcoreWl2.
  • Combine SetupEglWindow and SetupEglSurface into a single function SetupEGL.
  • Remove unnecessary private methods.
  • Add additional error descriptions for EGL errors.

Evas GL

  • Let SetupEvasWindow return bool to make the calling order consistent with Ecore Wl2.

@bwikbs
Copy link
Member

bwikbs commented Dec 6, 2021

The refactoring is neat and great! 👍
And.. What motivated you to do this? I wonder what's bothering you 😄

@swift-kim
Copy link
Member Author

swift-kim commented Dec 6, 2021

@bwikbs I was writing TizenRendererWayland (just for fun), and wanted to make the code style consistent across the renderers. :)

@bwikbs
Copy link
Member

bwikbs commented Dec 6, 2021

@swift-kim
You really hate efl!!! 😄

@swift-kim swift-kim requested a review from a team December 9, 2021 08:38
@swift-kim swift-kim changed the base branch from flutter-2.5.3-tizen to flutter-2.8.0-tizen December 9, 2021 09:32
bwikbs
bwikbs approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this! It's pretty cool! 👍

@swift-kim swift-kim merged commit e956bd3 into flutter-tizen:flutter-2.8.0-tizen Dec 13, 2021
swift-kim added a commit that referenced this pull request Dec 17, 2021
@swift-kim
Refactor TizenRenderers (#215)
f5ea3cc
swift-kim added a commit that referenced this pull request Feb 7, 2022
@swift-kim
Refactor TizenRenderers (#215)
6f45c99
swift-kim added a commit that referenced this pull request Feb 11, 2022
@swift-kim
Refactor TizenRenderers (#215)
10f64a3
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Refactor TizenRenderers (#215)
47c1907
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Refactor TizenRenderers (#215)
b2b89a2
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Refactor TizenRenderers (#215)
16e3bc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwikbs bwikbs bwikbs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swift-kim @bwikbs