-
Notifications
You must be signed in to change notification settings - Fork 17
Improve key event handling for TV remote controls #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve key event handling for TV remote controls #234
Conversation
|
I decided not to apply #221 right now because it adds too much complexity without much benefit. We still need to implement it in the near future in order to enable more key mapping (currently only keys that are listed in |
| uint32_t scan_code = key->keycode; | ||
| auto iter = kSymbolToScanCode.find(key->key); | ||
| if (iter != kSymbolToScanCode.end()) { | ||
| scan_code = iter->second; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This remapping is unavoidable because TV devices use their own key layout. For example, XF86SysMenu on TV remote control is defined as 0x00000085 (Meta Left). Remapping only logical key codes didn't work.
bbrto21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
After applying this PR, I confirmed that the "Not available" popup no longer appears on my TV with devel board |
|
@swift-kim, is there a reason it goes into Flutter 2.10 and not in 2.8? Can this be done for 2.8 as well? |
|
@AliaksandrTuzik We usually support only one Flutter version at a time (i.e. the flutter-tizen tool follows a linear versioning policy) to reduce maintenance workload and do not provide updates for older versions. However as flutter-tizen/flutter-tizen#326 has not been merged yet, we can release this patch for Flutter 2.8 first and then finish the migration to Flutter 2.10, if you want. How do you think? |
That would be great! |
* Improve key event handling for TV remote controls * Fix x64 build * Minimize key remapping * Rename kModifierMap
* Improve key event handling for TV remote controls * Fix x64 build * Minimize key remapping * Rename kModifierMap
* Improve key event handling for TV remote controls * Fix x64 build * Minimize key remapping * Rename kModifierMap
* Improve key event handling for TV remote controls * Fix x64 build * Minimize key remapping * Rename kModifierMap
* Improve key event handling for TV remote controls * Fix x64 build * Minimize key remapping * Rename kModifierMap
* Improve key event handling for TV remote controls * Fix x64 build * Minimize key remapping * Rename kModifierMap
Fixes flutter-tizen/flutter-tizen#319. Substitutes the previous change #232.
Changes
XF86AudioPlayPause) be redefinable by the app.ecore_wl2_window_keygrab_setandeext_win_keygrab_setwere used to override the system's default behavior.efl-extensiondependency (foreext_win_keygrab_set).RawKeyEvent.character.KeyEventHandler::OnKeyreturnECORE_CALLBACK_DONE(instead ofECORE_CALLBACK_PASS_ON) by default.modifierMeta(1 << 28to1 << 26).Cleanups
key→event).key_event_handler.ccandtouch_event_handler.ccanalogous to each other.To test this PR (details):