Skip to content

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Feb 24, 2022

Fixes #230.

  • Add the release job. The job should be added to the same workflow as the build job in order to use download-artifact.
  • Minor cleanups.
    • Support non-bash shell. I found that the Linux build step runs in non-bash shell and generates an error (not detected by GA runner as a failure) since [ci] Remove EFL from the Docker image #247.

      [1/9] CXX obj/flutter/shell/version/version.version.o
      [2/9] STAMP obj/flutter/shell/version/version.stamp
      [3/9] SOLINK ./libflutter_engine.so
      /__w/_temp/60f4062e-3cb9-4b1e-9ef0-7e336789af2d.sh: 24: [[: not found
      
    • Make expressions simple and consistent.

Test: https://github.com/swift-kim/engine/actions/runs/1891287349

@bbrto21
Copy link

bbrto21 commented Feb 25, 2022

Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(How about change this work flow name such as "Build and Release" or something more comprehensive?)

@swift-kim
Copy link
Member Author

How about change this work flow name such as "Build and Release" or something more comprehensive?

@bbrto21 Well, since the release job is not applicable for PR runs, it would be better to keep the current name. I don't have other good options right now.

@swift-kim swift-kim merged commit fb20304 into flutter-tizen:flutter-2.10.1-tizen Feb 28, 2022
swift-kim added a commit that referenced this pull request May 12, 2022
* Simplify expressions in build.yml

* Add the release job
swift-kim added a commit that referenced this pull request Aug 5, 2022
* Simplify expressions in build.yml

* Add the release job
swift-kim added a commit that referenced this pull request Sep 1, 2022
* Simplify expressions in build.yml

* Add the release job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically release CI build artifacts

2 participants