Skip to content

Refactor PlatformViewChannel #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2022
Merged

Refactor PlatformViewChannel #256

merged 3 commits into from
Mar 11, 2022

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Mar 8, 2022

  • Remove unused imports.
  • Rename variables and methods: view_instance → view.
  • Rename RemoveViewInstanceIfNeeded to RemoveViewIfExists.
  • Replace CurrentFocusedViewId with FindFocusedView.
  • Create FindViewById.
  • Avoid type deduction (auto).
  • Rename *_ptr variables (e.g. map_ptr to map).
  • Make public methods private.
  • Minor cleanups.

bwikbs
bwikbs approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a matter of preference, but I have no complaints at all. Still very good! 👍

@swift-kim swift-kim marked this pull request as draft March 10, 2022 01:34
@swift-kim swift-kim marked this pull request as ready for review March 10, 2022 02:01
@swift-kim
Copy link
Member Author

swift-kim commented Mar 10, 2022

I'm trying to follow the style guide as much as possible.

@swift-kim swift-kim merged commit c42525b into flutter-tizen:flutter-2.10.1-tizen Mar 11, 2022
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Refactor PlatformViewChannel (#256)
6dea731 
* Clean up platform_view_channel.cc

* Replace CurrentFocusedViewId with FocusedViewInstance
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Refactor PlatformViewChannel (#256)
8d8fb1c 
* Clean up platform_view_channel.cc

* Replace CurrentFocusedViewId with FocusedViewInstance
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Refactor PlatformViewChannel (#256)
bd3be1f 
* Clean up platform_view_channel.cc

* Replace CurrentFocusedViewId with FocusedViewInstance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwikbs bwikbs bwikbs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swift-kim @bwikbs