Skip to content

Conversation

@wanchao-xu
Copy link

  • The system setting provide enum value for font size (SYSTEM_SETTINGS_FONT_SIZE_SMALL, SYSTEM_SETTINGS_FONT_SIZE_NORMAL, SYSTEM_SETTINGS_FONT_SIZE_LARGE, SYSTEM_SETTINGS_FONT_SIZE_HUGE and SYSTEM_SETTINGS_FONT_SIZE_GIANT).
#define MIDDLE_FONT_DPI                   (-100)
#define SMALL_FONT_DPI                     (-80)
#define LARGE_FONT_DPI                      (-150)
#define HUGE_FONT_DPI                       (-190)
#define GIANT_FONT_DPI                      (-250)

@wanchao-xu wanchao-xu requested a review from a team March 23, 2022 01:59
@swift-kim
Copy link
Member

@WonyoungChoi Do you have any idea about the windows gclient sync failure? It keeps failing for some reason.

@WonyoungChoi
Copy link

@swift-kim It's strange.. I'm trying to reproduce the error on my local environment.

Error

________ running 'python3 src/flutter/tools/download_dart_sdk.py --fail-loudly' in 'C:\workspace\engine'
Traceback (most recent call last):

  File "src/flutter/tools/download_dart_sdk.py", line 293, in <module>

    sys.exit(Main())

  File "src/flutter/tools/download_dart_sdk.py", line 242, in Main

    version = utils.ReadVersionFile()

AttributeError: module 'utils' has no attribute 'ReadVersionFile'

Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change on mobile/wearable and it worked very well. Good job.

(But I personally wish there is a medium font size between "normal" and "large" because 1.5 feels too large, especially on wearable.)

@swift-kim
Copy link
Member

Will this feature be supported on TV devices as well? (e.g. by enabling Focus Magnification in the accessibility settings)

@wanchao-xu
Copy link
Author

wanchao-xu commented Mar 28, 2022

Will this feature be supported on TV devices as well? (e.g. by enabling Focus Magnification in the accessibility settings)

I don't find the font size setting on TV, so I think this feature isn't supported on TV. The accessibility settings has enlarge mode to magnify all widget, not only font. and enlarge is implemened by Tizen.TV.FLUX.NUI.

@swift-kim swift-kim merged commit aa0a787 into flutter-tizen:flutter-2.10.1-tizen Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants