Skip to content

Conversation

@swift-kim
Copy link
Member

Depend on libtzsh_softkey.so only when building for the common profile. The library and the Tizen Shell Softkey API are not available on Tizen 4.0 devices.

Fixes an app launch failure on Tizen 4.0 wearable caused by #251.

This issue has not been detected by the API checker until now probably because the TizenShell class is unused when building for other profiles than common and thus its compilation result is effectively optimized out. We need to use more #ifdefs in platform_channel.cc to make our intention clear.

@swift-kim swift-kim requested a review from a team April 27, 2022 09:22
@WonyoungChoi
Copy link

If so, is it possible to run the app in 4.0 common profile?

@swift-kim
Copy link
Member Author

@WonyoungChoi We don't support Tizen 4.0 + common profile. Tizen 4.0 support is only for the wearable profile.

https://github.com/flutter-tizen/flutter-tizen#supported-devices

Copy link

@WonyoungChoi WonyoungChoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@swift-kim swift-kim merged commit fa89823 into flutter-tizen:flutter-2.10.1-tizen Apr 28, 2022
swift-kim added a commit that referenced this pull request May 12, 2022
swift-kim added a commit that referenced this pull request Aug 5, 2022
swift-kim added a commit that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants