[ci] Change the release tag format #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There's still no response to my GitHub support ticket, and an action should be made as soon as possible (hopefully today). This change doesn't seem to be a too bad idea. |
|
looks good to me |
|
Looks good to me as well, maybe engine.version need to be changed in tools? |
Member
Author
|
@HakkyuKim Yes, right. I'll do that in flutter-tizen/flutter-tizen#366 when this PR gets merged. |
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As GitHub doesn't any more support a release tag name identical to the target commit hash (404 Not Found error), we need to use a different format for the tag name.
Old: Short commit hash (e.g.
abcdefg)New: Engine version + short commit hash (e.g.
3.0.0-abcdefg)Any suggestion? @flutter-tizen/maintainers