-
Notifications
You must be signed in to change notification settings - Fork 17
Enable mouse cursors for TV devices #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable mouse cursors for TV devices #290
Conversation
a475e75 to
674c117
Compare
|
All the changes in this PR look good to me., but unfortunately, the mouse cursor doesn't show up on my TV. cc @yman-son |
//TIZEN/[MAIN]/[ONEPROD_Prj]/[INT]/COMMON/Profile/platform/framework/web/chromium-efl/wrt/src/browser/tv/wrt_native_window_tv.cc I found the some different to get "surface" between your code and my code. Would you like to test by forcibly enabling the mouse cursor? |
| if (!Cursor_Set_Config(surface, 1, nullptr)) { | ||
| FT_LOG(Error) << "Failed to set a cursor configuration."; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dlclose doesn't need a call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I'll fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a call of CursorModule_Finalize() in my code~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 58adc7d.
I've been using this for a long time :) |
@yman-son Our embedder code doesn't rely on the Ecore Evas API but directly creates and manages Ecore Wl2 window instances. Thus it already has a reference to the window handle and a wayland surface can be retrieved from it. |
I can find log in dlog when cursor setting is successful. 145.059 I/VD_WIN_UTIL(P 7127, T 7127): cursor_module.c: Cursor_Set_Config(1046) > config_type as 1 |
|
@yman-son We can also see the log message you mentioned when the app launches. But the cursor only appears on the screen when force_enable_cursor is set to true. We want to enable the cursor even if the value is set to false (the default value). Are you testing with force_enable_cursor turned off? |
I test vconf in false state for WRT. (ex : tving) |
I applied the changed code with Kim's help and conducted the test on the TV. snapshot info : |
Thank you for checking. |
Fixes flutter-tizen/flutter-tizen#364. * Add the EnableCursor method to TizenWindowEcoreWl2 which is implemented for TV devices only. The method uses dlopen to invoke the Cursor_Set_Config function in libvd-win-util.so. * Style the code in SetTizenPolicyNotificationLevel in a consistent way. dlopen and dlsym should not affect the performance (launching time) noticeably.
Fixes flutter-tizen/flutter-tizen#364. * Add the EnableCursor method to TizenWindowEcoreWl2 which is implemented for TV devices only. The method uses dlopen to invoke the Cursor_Set_Config function in libvd-win-util.so. * Style the code in SetTizenPolicyNotificationLevel in a consistent way. dlopen and dlsym should not affect the performance (launching time) noticeably.
Fixes flutter-tizen/flutter-tizen#364.
EnableCursormethod toTizenWindowEcoreWl2which is implemented for TV devices only. The method uses dlopen to invoke theCursor_Set_Configfunction inlibvd-win-util.so.SetTizenPolicyNotificationLevelin a consistent way.dlopen and dlsym should not affect the performance (launching time) noticeably.