Skip to content

Conversation

@bbrto21
Copy link

@bbrto21 bbrto21 commented Jul 4, 2022

  • Calculate relative coordinates before delegating to the FlutterTizenView.

Signed-off-by: Boram Bae boram21.bae@samsung.com

* Calculate relative coordinates before delegating to the FlutterTizenView.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
@swift-kim
Copy link
Member

Could you describe what the bug was?

Does this change work for all possible cases, including TizenWindowElementary/TizenWindowEcoreWl2/TizenViewElementary and landscape/portrait?

@bbrto21
Copy link
Author

bbrto21 commented Jul 4, 2022

Could you describe what the bug was?

It caused by recent changes and can only be reproduced when the view type is Window. especially it happens when you use the window channel to move the window. you must change the mouse coordinates to relative coordinates only when the view type is not Window. The orientation of the device is irrelevant.

@swift-kim
Copy link
Member

@bbrto21 So what is the bug? What's not working?

@bbrto21
Copy link
Author

bbrto21 commented Jul 4, 2022

@bbrto21 So what is the bug? What's not working?

The mouse event coordinates are reduced by the distance the window moves.

@bbrto21 bbrto21 merged commit 782b415 into flutter-tizen:flutter-3.0.0-tizen Jul 5, 2022
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
* Calculate relative coordinates before delegating to the FlutterTizenView.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
* Calculate relative coordinates before delegating to the FlutterTizenView.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants