Ignore SystemChrome.setApplicationSwitcherDescription #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSUYA
reviewed
Jul 5, 2022
Member
JSUYA
left a comment
JSUYA
left a comment
There was a problem hiding this comment.
I think it's an appropriate message because it's actually unimplemented.
Is there any reason why we should hide this?
Member
Author
|
@JSUYA The Tizen platform doesn't support the functionality in the first place, so "unimplemented" is in fact misleading. It'd be better to make it just no-op. |
JSUYA
approved these changes
Jul 5, 2022
Member
JSUYA
left a comment
JSUYA
left a comment
There was a problem hiding this comment.
um.. If it is not supported, I think it may better print "unsupported".
Anyway. I got it.
Member
Author
|
The API documentation says
so it should be safe to return |
bbrto21
approved these changes
Jul 5, 2022
JSUYA
approved these changes
Jul 5, 2022
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not print the "unimplemented method" warning when run with the
--verbose-system-logsoption. The method is always called when the Title widget rebuilds.