Skip to content

Add FlutterDesktopViewGetNativeHandle #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2022
Merged

Add FlutterDesktopViewGetNativeHandle #314

merged 4 commits into from
Aug 16, 2022

Conversation

@Swanseo0
Copy link

@Swanseo0 Swanseo0 commented Jul 13, 2022

  • Makes all tizen view types be able to get target container handle.

bbrto21
bbrto21 reviewed Jul 14, 2022
View reviewed changes
Copy link

@bbrto21 bbrto21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution.

JSUYA
JSUYA reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the name Container appropriate?
How about NativeHandle? I think we can come up with a better name.

@bbrto21 bbrto21 linked an issue Jul 14, 2022 that may be closed by this pull request
Provides API to pass native handle of Tizen view to user #313
Closed
swift-kim
swift-kim reviewed Jul 14, 2022
View reviewed changes
@Swanseo0
Copy link
Author

Swanseo0 commented Jul 14, 2022

Is the name Container appropriate? How about NativeHandle? I think we can come up with a better name.

When I read and thought about what you said, Container seemed to have a strong content of the Container Object of the view elementary. But NativeHandle seems to be more suitable in the sense of the handle of container and window.

@Swanseo0 Swanseo0 force-pushed the swan/dev branch 2 times, most recently from df099bb to a3ca75c Compare July 14, 2022 07:05
@Swanseo0 Swanseo0 changed the title Add FlutterDesktopViewGetContainer Add FlutterDesktopViewGetNativeHandle Jul 14, 2022
bbrto21
bbrto21 approved these changes Jul 14, 2022
View reviewed changes
Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I leave a few more comments below.

swift-kim
swift-kim approved these changes Aug 1, 2022
View reviewed changes
@swift-kim
Copy link
Member

swift-kim commented Aug 2, 2022

Is the tool side PR ready? Make sure to remove FlutterDesktopPluginRegistrarGetNativeWindow from the C# embedding's Interop.cs.

@Swanseo0
Copy link
Author

Swanseo0 commented Aug 2, 2022

Is the tool side PR ready? Make sure to remove FlutterDesktopPluginRegistrarGetNativeWindow from the C# embedding's Interop.cs.

When this PR enters, a PR that applies modifications to the flutter-tizen repo is prepared.

  • Change Engine hash
  • Remove FlutterDesktopPluginRegistrarGetNativeWindow
  • Add FlutterDesktopPluginRegistrarGetView
  • Add FlutterDesktopViewGetNativeHandle

@Swanseo0 Swanseo0 force-pushed the swan/dev branch 2 times, most recently from b636a5d to d707a7c Compare August 10, 2022 10:02
@Swanseo0 Swanseo0 changed the base branch from flutter-3.0.0-tizen to flutter-3.0.5-tizen August 10, 2022 10:55
@Swanseo0
Add FlutterDesktopViewGetContainer
19166cd 
* Makes all tizen view types be able to get target container handle.

Signed-off-by: swan.seo <swan.seo@samsung.com>
@Swanseo0
Apply reviewer's comment
2c5b064
@Swanseo0
Apply reviewer's comment
a539b02 
 - Remove FlutterDesktopPluginRegistrarGetNativeHandle
 - Add FlutterDesktopPluginRegistrarGetView
@Swanseo0
Apply reviewer's comment
a13966d 
 - Change the order of the declaration of GetRenderTargetDisplay and GetNativeHandle
This was referenced Aug 12, 2022
Merged
Merged
@swift-kim swift-kim merged commit 0948a08 into flutter-tizen:flutter-3.0.5-tizen Aug 16, 2022
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@Swanseo0 @swift-kim
Add FlutterDesktopViewGetNativeHandle (#314)
07f9e3d 
Makes all tizen view types be able to get target container handle.

Signed-off-by: swan.seo <swan.seo@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

@bwikbs bwikbs bwikbs left review comments

@JSUYA JSUYA JSUYA left review comments

@swift-kim swift-kim swift-kim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provides API to pass native handle of Tizen view to user

5 participants

@Swanseo0 @swift-kim @bbrto21 @bwikbs @JSUYA