Restore support for pixel buffer textures #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSUYA
approved these changes
Aug 1, 2022
Member
Author
|
The CI build is stuck at "gclient sync" for unknown reason. |
xiaowei-guan
approved these changes
Aug 1, 2022
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Organize build dependencies * Support pixel type external textures
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Organize build dependencies * Support pixel type external textures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #321. This change is a partial revert of d06b6fa.
Also resolves #312 (comment).
We can't avoid a certain amount of code duplication because
external_texture_pixel_egl.ccandexternal_texture_pixel_evas_gl.ccshould both be compiled into a single binary. Please let me know if there's any better design.Previous discussion: #312 (comment)