Introduce TizenViewNui #328

JSUYA · 2022-08-16T05:56:25Z

This is a View Class that supports NUI UIFW that inherits TizenView.
NUI is a UIFW based on the C# language that wrapping Dali UIFW.

The mouse and the keyboard event callback handling for NUI is handled in embedding(C#).
The embedder handles events related to event delivery and rendering.
Basically draw a flutter on a NativeImageQueue created from embedding.
This corresponds to tbm_surface_queue_h and is rendered flutter view using egl.
(When taking tbm_surface_queue_h from NativeImageQueue, typeid() is used inside dali,
so -rtti flag is absolutely necessary.)

JSUYA · 2022-08-18T01:49:17Z

shell/platform/common/BUILD.gn

+  configs -= [ "//build/config/compiler:no_rtti" ]
+  configs += [ "//build/config/compiler:rtti" ]


enable_nui_support variable information set in shell/platform/tizen/BUILD.gn cannot be imported into this context.
If you know how to pass nui support info to this file and the gn file of accessibility, please let me know.

JSUYA · 2022-08-19T04:29:56Z

Hi @swift-kim I think the PR is roughly ready. Please review this pr.

+)

Since dali is a package compiled with rtti, the no_rtti config must be removed.
I wanted to remove the code that excludes no_rtti from shell/platform/common/BUILD.gn and third_party/accessibility/ax/BUILD.gn but couldn't find a way.

If we remove the code that exclude the no_rtti

obj/flutter/shell/platform/tizen/libflutter_tizen_mobile_nui.flutter_platform_node_delegate_tizen.o:(.data.rel.ro._ZTIN7flutter32FlutterPlatformNodeDelegateTizenE+0x8): undefined reference to `typeinfo for flutter::FlutterPlatformNodeDelegate'
obj/flutter/shell/platform/tizen/libflutter_tizen_mobile_nui.flutter_platform_node_delegate_tizen.o:(.data.rel.ro._ZTIN7flutter34FlutterPlatformWindowDelegateTizenE+0x8): undefined reference to `typeinfo for ui::AXPlatformNodeDelegateBase'
obj/flutter/shell/platform/tizen/libflutter_tizen_mobile_nui.flutter_platform_node_delegate_tizen.o:(.data.rel.ro._ZTIN7flutter31FlutterPlatformAppDelegateTizenE+0x8): undefined reference to `typeinfo for ui::AXPlatformNodeDelegateBase'

This link error occurs.

Since we don't use dynamic_cast or typeid, I thought we could solve this problem.
and I thought there was a problem with the implementation of flutter_platform_node_delegate_tizen.h and the FlutterPlatformNodeDelegateTizen class defined in the header.
(Probably not implementing parent's virtual function enough)
I've been looking for unimplemented method in this class, but haven't found any particular problems.
(@bbrto21 also said that he did research similar to mine to minimize rtti option changes, but couldn't find a way.)

For now, I think it's okay to leave the build config removing no_rtti as it is, unless it's a problem.(it may have a slight impact on the size or performance of the result.)

If you have any good workarounds or ideas, please share me.

swift-kim · 2022-08-22T07:58:27Z

shell/platform/common/BUILD.gn

  public_configs =
      [ "//flutter/third_party/accessibility:accessibility_config" ]

+  configs -= [ "//build/config/compiler:no_rtti" ]


I couldn't find a way to skip this part either. Actually I don't understand why the "undefined reference" error occurs for accessibility-related classes only.

shell/platform/tizen/BUILD.gn

shell/platform/tizen/flutter_tizen.cc

shell/platform/tizen/public/flutter_tizen.h

shell/platform/tizen/tizen_renderer_egl.cc

shell/platform/tizen/tizen_view_nui.cc

shell/platform/tizen/tizen_view_nui.h

shell/platform/tizen/flutter_tizen.cc

shell/platform/tizen/flutter_tizen_view.cc

swift-kim · 2022-08-24T06:18:38Z

shell/platform/tizen/public/flutter_tizen.h

+FLUTTER_EXPORT void FlutterDesktopViewOnPointerEvent(
+    FlutterDesktopViewRef view,
+    FlutterDesktopPointerEventType type,
+    double x,
+    double y,
+    size_t timestamp,
+    int32_t device_id);


Doesn't NUI support scroll events?

I haven't checked dali's scroll event yet.
I want to work on this in another PR if you are ok.

shell/platform/tizen/public/flutter_tizen.h

swift-kim · 2022-08-24T06:27:49Z

shell/platform/tizen/tizen_view_nui.h

+#include <dali-toolkit/public-api/controls/image-view/image-view.h>
+#include <dali/devel-api/adaptor-framework/event-thread-callback.h>
+#include <dali/devel-api/adaptor-framework/native-image-source-queue.h>
+#include <dali/devel-api/common/stage.h>


Does devel-api mean that the APIs are not finalized and subject to change in the future?

As far as I know the devel-api is for inhouse app developers. it didn't ACR.
The APIs we use are open as DALI_ADAPTOR_API.

subject to change in the future?

It could change, but I think it's unlikely.

shell/platform/tizen/tizen_view_nui.h

swift-kim

Many thanks!

This is a View Class that supports NUI UIFW that inherits TizenView. NUI is a UIFW based on the C# language that wrapping Dali UIFW. The mouse and the keyboard event callback handling for NUI is handled in embedding(C#). The embedder handles events related to event delivery and rendering. Basically draw a flutter on a NativeImageQueue created from embedding. This corresponds to tbm_surface_queue_h and is rendered flutter view using egl. (When taking tbm_surface_queue_h from NativeImageQueue, typeid() is used inside dali, so -rtti flag is absolutely necessary.)

Currently, when I resize FlutterView, there is a problem that render sync does not match. The last updated flutterview is not drawn to the target. onMakeCurrent and onPresent are called every frame update. Because onPresent is called later than onMakeCurrent, it can temporarily solve the current problem.

This reverts commit 7dd6bec.

This is a View Class that supports NUI UIFW that inherits TizenView. NUI is a UIFW based on the C# language that wrapping Dali UIFW. The mouse and the keyboard event callback handling for NUI is handled in embedding(C#). The embedder handles events related to event delivery and rendering. Basically draw a flutter on a NativeImageQueue created from embedding. This corresponds to tbm_surface_queue_h and is rendered flutter view using egl. (When taking tbm_surface_queue_h from NativeImageQueue, typeid() is used inside dali, so -rtti flag is absolutely necessary.) Co-authored-by: Swift Kim <swift.kim@samsung.com>

JSUYA marked this pull request as draft August 16, 2022 05:56

JSUYA force-pushed the dev/tizenviewnui branch 3 times, most recently from 5bbdf4a to 103c2d7 Compare August 16, 2022 09:18

JSUYA changed the title ~~(draft)Introduce TizenViewNui~~ Introduce TizenViewNui Aug 16, 2022

JSUYA force-pushed the dev/tizenviewnui branch from 103c2d7 to d53c128 Compare August 18, 2022 01:43

JSUYA commented Aug 18, 2022

View reviewed changes

JSUYA marked this pull request as ready for review August 19, 2022 04:30

JSUYA mentioned this pull request Aug 19, 2022

Introduce NUIFlutterView class flutter-tizen/flutter-tizen#418

Merged

swift-kim reviewed Aug 22, 2022

View reviewed changes

swift-kim reviewed Aug 23, 2022

View reviewed changes

swift-kim reviewed Aug 24, 2022

View reviewed changes

swift-kim approved these changes Aug 25, 2022

View reviewed changes

swift-kim mentioned this pull request Aug 26, 2022

[tizen_app_control] Improve FFI symbol resolution flutter-tizen/plugins#429

Merged

JSUYA and others added 13 commits August 30, 2022 15:12

Configure tizen/BUILD.gn

3cf0100

Fix rebase conflict

9d129a7

fix typo

a2879eb

Clean up build config

e22c8b5

Clean up code

e3dbea9

Change callback function name

0d81548

Change parameter type int32_t instead of int

e134709

Clean up code

25571dd

Fix name

fd0b68c

Compare view size to avoid duplicate resize

7dd6bec

Revert "Compare view size to avoid duplicate resize"

7bfd4ea

This reverts commit 7dd6bec.

JSUYA force-pushed the dev/tizenviewnui branch from 69d4618 to 7bfd4ea Compare August 30, 2022 07:49

JSUYA merged commit e75d0ec into flutter-tizen:flutter-3.0.5-tizen Aug 31, 2022

		configs -= [ "//build/config/compiler:no_rtti" ]
		configs += [ "//build/config/compiler:rtti" ]

Introduce TizenViewNui #328

Introduce TizenViewNui #328

Uh oh!

Conversation

JSUYA commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JSUYA Aug 18, 2022

Choose a reason for hiding this comment

Uh oh!

JSUYA commented Aug 19, 2022

Uh oh!

swift-kim Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

swift-kim Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

JSUYA Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swift-kim Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

JSUYA Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swift-kim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JSUYA commented Aug 16, 2022 •

edited

Loading