Use evas_object_image as mouse event target #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use ecore_evas_window_get instead of ecore_evas_window_get. * Fix flutter-tizen/flutter-tizen/issues/424 Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bbrto21
force-pushed
the
fix_touch_on_tizen_4.0_emul
branch
from
35b918e to
f2d95b4
Compare
JSUYA
reviewed
Aug 19, 2022
Member
JSUYA
left a comment
JSUYA
left a comment
There was a problem hiding this comment.
Please check UnRegisterEventHandlers method.
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
reviewed
Aug 19, 2022
| image_, EVAS_CALLBACK_MOUSE_WHEEL, | ||
| evas_object_callbacks_[EVAS_CALLBACK_MOUSE_WHEEL], this); | ||
|
|
||
| evas_object_callbacks_[EVAS_CALLBACK_KEY_DOWN] = [](void* data, Evas* evas, |
Member
There was a problem hiding this comment.
Only apply to mouse events but not key events?
Member
There was a problem hiding this comment.
As far as I know evas_image is not suitable for receiving key events.
I know that the key problem was solved by modifying GetWindowID().
When I tested this PR, the key event did or didn't because of ime...
I don't think this is a problem with event callbacks....
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Use ecore_evas_window_get instead of ecore_evas_window_get. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boram Bae boram21.bae@samsung.com