Skip to content

Ignore SystemChrome.setSystemUIOverlayStyle #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Ignore SystemChrome.setSystemUIOverlayStyle #350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dfe24e
Ignore SystemChrome.setSystemUIOverlayStyle
swift-kim Sep 16, 2022
9e87c46
Combine two methods
swift-kim Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions shell/platform/tizen/channels/platform_channel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ constexpr char kSetEnabledSystemUiOverlaysMethod[] =
"SystemChrome.setEnabledSystemUIOverlays";
constexpr char kSetPreferredOrientationsMethod[] =
"SystemChrome.setPreferredOrientations";
constexpr char kSetSystemUIOverlayStyleMethod[] =
"SystemChrome.setSystemUIOverlayStyle";

constexpr char kTextKey[] = "text";
constexpr char kValueKey[] = "value";
Expand Down Expand Up @@ -127,9 +129,6 @@ void PlatformChannel::HandleMethodCall(
} else if (method == kRestoreSystemUiOverlaysMethod) {
RestoreSystemUiOverlays();
result->Success();
} else if (method == kSetApplicationSwitcherDescriptionMethod) {
// Not supported on Tizen. Ignore.
result->Success();
} else if (method == kSetEnabledSystemUiOverlaysMethod) {
const rapidjson::Document& list = arguments[0];
std::vector<std::string> overlays;
Expand All @@ -146,6 +145,10 @@ void PlatformChannel::HandleMethodCall(
}
SetPreferredOrientations(orientations);
result->Success();
} else if (method == kSetApplicationSwitcherDescriptionMethod ||
method == kSetSystemUIOverlayStyleMethod) {
// Not supported on Tizen. Ignore.
result->Success();
} else {
FT_LOG(Info) << "Unimplemented method: " << method;
result->NotImplemented();
Expand Down