Add TizenView::Unfocus() method #352
Conversation
* When Blur() is called, the view no longer handles key-events. As a result the keyboard focus can be removed from the view. * Now, if a backkey is pressed when the navigation stack is empty, the view loses keyboard focus by Platform channel with TizenViewElementary. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
|
Maybe |
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Ok, I updated PR as your comment. |
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
| } | ||
|
|
||
| void TizenViewNui::Unfocus() { | ||
| FT_UNIMPLEMENTED(); |
There was a problem hiding this comment.
Is this difficult to implement?
There was a problem hiding this comment.
As you can see. nui implementation is quite different from elementary implementation.
I don't know much about this yet, and I have to study it. I need more time for this. so I want to leave this part for next PR.
There was a problem hiding this comment.
Since NUI's TouchEvent Callback is located in flutter-tizen, it should be implemented with flutter-tizen(with additional APIs(?)). I will check after this patch is applied.
There was a problem hiding this comment.
I think we should finalize the design before applying this change.
There was a problem hiding this comment.
Ah, then, it seems that the Unfocus() method and the focused member should be implemented in TizenView.
There was a problem hiding this comment.
I made a PR applicable to NUIView. (#354)
I changed Unfocus() to SetFocus(bool f) because there are cases where I need to make focused_ true.
* Tidy up based on review. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
3 participants
Signed-off-by: Boram Bae boram21.bae@samsung.com