[webview_flutter] Apply upstream (webview_flutter-v2.1.1) #236

bwikbs · 2021-10-07T01:16:46Z

Signed-off-by: MuHong Byun mh.byun@samsung.com

bwikbs · 2021-10-07T01:56:59Z

@HakkyuKim @swift-kim @bbrto21
I guess.. It seems necessary to upload the flutter version to the analyze task. When should we do it?

HakkyuKim · 2021-10-07T02:22:27Z

It seems that flutter analyze became similar to dart analyze after bumping to 2.5.1. The warnings look similar to #223.

HakkyuKim · 2021-10-07T02:31:05Z

I can resolve most errors/warnings in #234 except for "Document all public members" for url_launcher and webview_flutter as I'm not the writer of those packages.

bwikbs · 2021-10-07T02:54:22Z

@HakkyuKim 👌 I'll do that stuff!

swift-kim · 2021-10-07T05:23:26Z

👌 I'll do that stuff!

@bwikbs Could you make it as a separate PR? This PR is supposed to only change webview_flutter-related things.

bwikbs · 2021-10-07T05:48:02Z

@bwikbs Could you make it as a separate PR? This PR is supposed to only change webview_flutter-related things.

Sure~. It's was just for testing purposes. Don't worry 😄
(I just wanted to know how much task was remained.)

HakkyuKim · 2021-10-07T05:54:20Z

@bwikbs
I'll add // ignore_for_file: public_member_api_docs for url_launcher to #234. Then we can first merge #234 tomorrow after I fix the server for testing package_info_plus. You can put webview_flutter changes here after rebasing it to master. Is this OK?

bwikbs · 2021-10-07T06:01:17Z

@HakkyuKim 🙆‍♂️

bwikbs · 2021-10-08T04:26:55Z

@HakkyuKim I have simple question!
When do we apply '2.5.1'?

#234 -> apply '2.5.1' -> #236 OR #234 -> #236 -> apply '2.5.1' ?
Either way ci would fail in step 2? Which one is better?

HakkyuKim · 2021-10-08T04:38:53Z

@bwikbs
You can apply '2.5.1' to the CI script in this PR as done in #216 since it's necessary for this package update.
So #234 -> #236 (which includes updating the CI script to '2.5.1').

bwikbs · 2021-10-08T04:55:10Z

@HakkyuKim
Got it! thanks! 😄

swift-kim · 2021-10-08T05:44:24Z

Beware that updating the flutter-version in https://github.com/flutter-tizen/plugins/blob/master/.github/workflows/analyze.yml may break things since Dart 2.12 and 2.14 use different formatting for cascades. Thus it would be better to make it as a separate PR.

HakkyuKim · 2021-10-08T06:15:18Z

@swift-kim @bwikbs
In that case, I'll update flutter-version of the CI script first in a separate PR.

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bwikbs · 2021-10-08T07:17:28Z

After a short discussion, we decided to include #240 to this PR.

HakkyuKim

Could you also update to

dependencies:
  webview_flutter_tizen: ^0.3.7

in packages/webview_flutter/README.md?

.github/workflows/analyze.yml

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bwikbs · 2021-10-12T06:39:03Z

Could you also update to
dependencies:
  webview_flutter_tizen: ^0.3.7
in packages/webview_flutter/README.md?

!!! Good point! 👍

HakkyuKim

LGTM

swift-kim · 2021-10-13T01:18:03Z

packages/webview_flutter/pubspec.yaml

  flutter:
    sdk: flutter
-  webview_flutter: ^2.0.4
+  webview_flutter: ^2.1.1


I don't care but please be aware of the implicit indirect dependency (webview_flutter → webview_flutter_platform_interface).

I'm sorry 😢 I can't get your point. What do you concern about?

Why don't you explicitly add a dependency about webview_flutter_platform_interface?

webview_flutter_platform_interface is dependent webview_flutter. Do I have to use it unconditionally to use a higher version of webview_flutter?
What's the point of being explicit? (I'm really curious to ask... )

The webview_flutter_tizen package is an implementation of webview_flutter_platform_interface, so it's very natural to specify which version of webview_flutter_platform_interface the package implements.

You're right! I'll fix it!

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

swift-kim · 2021-10-14T06:05:25Z

@bwikbs The person who merged a PR marked as "needs-publishing" is responsible for publishing the updated package. Please ask @bbrto21 if you don't know how to.

bwikbs · 2021-10-14T06:26:40Z

@swift-kim I've already did that. Thanks for letting me know anyway. 😄

…zen#236) * [webview_flutter] Apply upstream (webview_flutter-v2.1.1) Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Add reviewer's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Add reviewer's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com>

github-actions bot added needs-publishing The package should be published after merge p: webview_flutter labels Oct 7, 2021

bwikbs force-pushed the work_webview branch from c611a06 to 64b501d Compare October 7, 2021 01:19

bwikbs force-pushed the work_webview branch from 65947d3 to 13bec89 Compare October 7, 2021 02:51

bwikbs force-pushed the work_webview branch 4 times, most recently from 3901290 to 63c1e53 Compare October 7, 2021 04:49

github-actions bot added p: messageport p: package_info_plus p: path_provider p: permission_handler p: share_plus p: wearable_rotary labels Oct 7, 2021

bwikbs force-pushed the work_webview branch from 63c1e53 to 5cc1eef Compare October 7, 2021 04:56

github-actions bot added the p: url_launcher label Oct 7, 2021

bwikbs force-pushed the work_webview branch from 5cc1eef to 22cb639 Compare October 8, 2021 03:07

bwikbs force-pushed the work_webview branch from 22cb639 to 6fecba2 Compare October 8, 2021 04:29

github-actions bot removed p: path_provider p: share_plus p: package_info_plus labels Oct 8, 2021

github-actions bot removed p: url_launcher p: permission_handler p: wearable_rotary p: messageport labels Oct 8, 2021

[webview_flutter] Apply upstream (webview_flutter-v2.1.1)

4251ecb

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

HakkyuKim mentioned this pull request Oct 8, 2021

Update flutter version in CI script #240

Closed

bwikbs force-pushed the work_webview branch from 6fecba2 to 4251ecb Compare October 8, 2021 07:03

bwikbs marked this pull request as ready for review October 8, 2021 07:12

HakkyuKim reviewed Oct 12, 2021

View reviewed changes

bbrto21 reviewed Oct 12, 2021

View reviewed changes

.github/workflows/analyze.yml Show resolved Hide resolved

Add reviewer's comment

86ed7f7

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

HakkyuKim approved these changes Oct 12, 2021

View reviewed changes

swift-kim reviewed Oct 13, 2021

View reviewed changes

Add reviewer's comment

6bdbc0c

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bwikbs merged commit 8a21e27 into flutter-tizen:master Oct 14, 2021

HakkyuKim mentioned this pull request Oct 19, 2021

Public members lack documentation #223

Closed

59 tasks

[webview_flutter] Apply upstream (webview_flutter-v2.1.1) #236

[webview_flutter] Apply upstream (webview_flutter-v2.1.1) #236

Uh oh!

Conversation

bwikbs commented Oct 7, 2021

Uh oh!

bwikbs commented Oct 7, 2021

Uh oh!

HakkyuKim commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HakkyuKim commented Oct 7, 2021

Uh oh!

bwikbs commented Oct 7, 2021

Uh oh!

swift-kim commented Oct 7, 2021

Uh oh!

bwikbs commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HakkyuKim commented Oct 7, 2021

Uh oh!

bwikbs commented Oct 7, 2021

Uh oh!

bwikbs commented Oct 8, 2021

Uh oh!

HakkyuKim commented Oct 8, 2021

Uh oh!

bwikbs commented Oct 8, 2021

Uh oh!

swift-kim commented Oct 8, 2021

Uh oh!

HakkyuKim commented Oct 8, 2021

Uh oh!

bwikbs commented Oct 8, 2021

Uh oh!

HakkyuKim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bwikbs commented Oct 12, 2021

Uh oh!

HakkyuKim left a comment

Choose a reason for hiding this comment

Uh oh!

swift-kim Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

bwikbs Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

bbrto21 Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

bwikbs Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

swift-kim Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

bwikbs Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

swift-kim commented Oct 14, 2021

Uh oh!

bwikbs commented Oct 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HakkyuKim commented Oct 7, 2021 •

edited

Loading

bwikbs commented Oct 7, 2021 •

edited

Loading