-
Notifications
You must be signed in to change notification settings - Fork 52
[tizen_app_control] Add tizen_app_control package #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tizen_app_control] Add tizen_app_control package #216
Conversation
|
@HakkyuKim The CI build failed due to missing certificate profile. Can we add a certificate profile to the CI server? |
|
It would be important to note that the |
ffe8d25 to
d29a820
Compare
#217 should solve the problem. |
|
@HakkyuKim Oops. I've already done the same thing in e3387a9. Should I revert? |
|
@swift-kim |
pkosko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks very good. Approve from me.
|
LGTM after solving:
I also couldn't think of a right solution. If Tizen has no preferred way of handling this, maybe the API should document the fact so users can use |
|
@HakkyuKim Thanks. I added some comments but didn't specify a preferred way to deal with the situation. My personal recommendation is to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swift-kim
Cool, didn't know that I could wrap a Future and cancel it. LGTM.
Contributes to flutter-tizen/flutter-tizen#210.
Depends on flutter-tizen/engine#183 and flutter-tizen/engine#184 (
AZURE_BUILD_ID=565).tizen_app_control is now a separate package from the internal tizen_core package. The API is similar to tizen_core's, but the implementation, example, and integration_test have almost been re-written from scratch.
Notable API changes:
AppControl.createAppControlandAppControl.disposehave been removed in favor of the new finalizable Dart objects (Remove the app_control reply channel engine#183).Map<String, dynamic>replaces the typeAppControlExtraData.ReceivedAppControlclass has been added. (Reference: TizenFX's ReceivedAppControl class)AppManager.terminateBackgroundApplicationandAppManager.isRunninghave been added to support terminating service applications. (Reference: TizenFX's ApplicationManager class)After publishing this package, we may:
AppControlimplementation from tizen_core.Although this package is technically a pure Dart package, I decided to place it in this repo because it heavily depends on the embedder's native implementation.