Skip to content

[webview_flutter] Apply texture API change #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

[webview_flutter] Apply texture API change #345

merged 1 commit into from
Apr 18, 2022

Conversation

@bwikbs
Copy link
Member

@bwikbs bwikbs commented Mar 26, 2022 •
edited
Loading

@github-actions github-actions bot added needs-publishing The package should be published after merge p: webview_flutter labels Mar 26, 2022
@bwikbs bwikbs marked this pull request as ready for review March 27, 2022 22:59
@swift-kim swift-kim mentioned this pull request Mar 28, 2022
Merged
@HakkyuKim
Copy link
Contributor

HakkyuKim commented Mar 28, 2022

Integration test CI is fixed. I'll rerun the test.

@bbrto21
Copy link
Contributor

bbrto21 commented Apr 7, 2022 •
edited
Loading

@bwikbs
I've test this PR on my TM1, but I got a green screen... Could you check this once again?
(Maybe it's because my TM1 is unstable.)

@bwikbs
Copy link
Member Author

bwikbs commented Apr 11, 2022

@bbrto21
Sorry for the slow reply.

I've test this PR on my TM1, but I got a green screen...

But is it real? I'll check it out and let you know when I get back to the office.

@bwikbs
[webview_flutter] Apply texture api change
d549c8a 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Copy link
Member Author

bwikbs commented Apr 18, 2022

@bbrto21
Plz, Test again.
Its behavior was confirmed in the tm1 and the emulator(mobile 6.5).

bbrto21
bbrto21 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first screen still shows a green screen. However, I guess it is not this PR-related issue.
so I approve this pr.

@swift-kim swift-kim changed the title [webview_flutter] Apply texture api change [webview_flutter] Apply texture API change Apr 18, 2022
@swift-kim swift-kim merged commit 14fb8b8 into flutter-tizen:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

Assignees

No one assigned

Labels

needs-publishing The package should be published after merge p: webview_flutter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bwikbs @HakkyuKim @bbrto21 @swift-kim